-
Notifications
You must be signed in to change notification settings - Fork 30
8249867: XML declaration is not followed by a newline #178
Conversation
👋 Welcome back yan! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed change looks good to me.
Thanks,
Andrew
@yan-too This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
The changes in original are all in copyright/comments, so this backport may be considered clean. We should wait for CSR approval, however.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/178/head:pull/178
$ git checkout pull/178
Update a local copy of the PR:
$ git checkout pull/178
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/178/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 178
View PR using the GUI difftool:
$ git pr show -t 178
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/178.diff