Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249867: XML declaration is not followed by a newline #178

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Feb 15, 2022

The changes in original are all in copyright/comments, so this backport may be considered clean. We should wait for CSR approval, however.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8249867: XML declaration is not followed by a newline
  • JDK-8259352: Documenting the implementation specific features and properties (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/178/head:pull/178
$ git checkout pull/178

Update a local copy of the PR:
$ git checkout pull/178
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/178/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 178

View PR using the GUI difftool:
$ git pr show -t 178

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/178.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 69ee314b63a9f260e3dcbe9ccd67ddc4faec3ba0 8249867: XML declaration is not followed by a newline Feb 15, 2022
@openjdk
Copy link

openjdk bot commented Feb 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 15, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2022

Webrevs

bae
bae approved these changes Feb 16, 2022
Copy link
Collaborator

@bae bae left a comment

The proposed change looks good to me.

Thanks,
Andrew

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249867: XML declaration is not followed by a newline

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8d25af4: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Feb 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

Going to push as commit b01d979.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 8d25af4: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2022
@openjdk openjdk bot closed this Feb 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@yan-too Pushed as commit b01d979.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8249867 branch Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants