-
Notifications
You must be signed in to change notification settings - Fork 30
8276141: XPathFactory set/getProperty method #179
Conversation
👋 Welcome back yan! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed change looks fine.
Thanks,
Andrew
@yan-too This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
Thanks,
Andrew
/integrate |
Going to push as commit b98036f.
Your commit was automatically rebased without conflicts. |
get/setProperty added plus test and presumably CSR; difference from the original is in LAstModified of XPathFactoryImpl.java and the test context.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/179/head:pull/179
$ git checkout pull/179
Update a local copy of the PR:
$ git checkout pull/179
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/179/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 179
View PR using the GUI difftool:
$ git pr show -t 179
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/179.diff