Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8251549: Update docs on building for Git #18

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 6, 2021

jdk15u is in process of migrating to Git (jdk15u-dev is already there), so we would need a variant of this document in 15u, too.
This exact patch applies clean.
Yes, clean with some chunks shifted the uniform 42 lines. These lines, it seems to me, belong mostly to updates JDK-8256182 and JDK-8247591 and are irrelevant to this task.

I have plan for making building.html as a separate task -- a backport of JDK-8257224 if possible but maybe not.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/18.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 042734cc5b17302a8f2ecdf577511bd6d5ec5e22 8251549: Update docs on building for Git Apr 6, 2021
@openjdk
Copy link

openjdk bot commented Apr 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 6, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251549: Update docs on building for Git

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 6, 2021

Webrevs

@yan-too
Copy link
Collaborator Author

yan-too commented Apr 7, 2021

/integrate

@openjdk openjdk bot closed this Apr 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2021
@openjdk
Copy link

openjdk bot commented Apr 7, 2021

@yan-too Pushed as commit 6cf1c0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8251549 branch April 7, 2021 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant