This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jdk15u is in process of migrating to Git (jdk15u-dev is already there), so we would need a variant of this document in 15u, too.
This exact patch applies clean.
Yes, clean with some chunks shifted the uniform 42 lines. These lines, it seems to me, belong mostly to updates JDK-8256182 and JDK-8247591 and are irrelevant to this task.
I have plan for making building.html as a separate task -- a backport of JDK-8257224 if possible but maybe not.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/18/head:pull/18
$ git checkout pull/18
Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/18/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18
View PR using the GUI difftool:
$ git pr show -t 18
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/18.diff