Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8261534: Test sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java fails on platforms where no nsslib artifacts are defined #182

Closed
wants to merge 1 commit into from

Conversation

eastig
Copy link
Member

@eastig eastig commented Feb 23, 2022

JDK-8259319 was backported to 15u. As we see the test failing, we need to backport this testfix to 15u as well. Patch applies cleanly. No risk, testfix only.
Tested:

  • make run-test TEST=sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java: Passed

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8261534: Test sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java fails on platforms where no nsslib artifacts are defined

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/182/head:pull/182
$ git checkout pull/182

Update a local copy of the PR:
$ git checkout pull/182
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 182

View PR using the GUI difftool:
$ git pr show -t 182

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/182.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2022

👋 Welcome back eastig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dc46aa85c6e16cb904d1c40a4577b5e48c56a3d4 8261534: Test sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java fails on platforms where no nsslib artifacts are defined Feb 23, 2022
@openjdk
Copy link

openjdk bot commented Feb 23, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@eastig This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261534: Test sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java fails on platforms where no nsslib artifacts are defined

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 23, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2022

Webrevs

@eastig
Copy link
Member Author

eastig commented Feb 24, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 24, 2022
@openjdk
Copy link

openjdk bot commented Feb 24, 2022

@eastig
Your change (at version 319db10) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Feb 24, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 24, 2022

Going to push as commit 1a1dec4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 24, 2022
@openjdk openjdk bot closed this Feb 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 24, 2022
@openjdk
Copy link

openjdk bot commented Feb 24, 2022

@yan-too @eastig Pushed as commit 1a1dec4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants