Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264823: Update building.html document for Git in jdk15u #19

Closed
wants to merge 1 commit into from

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 7, 2021

To generate this HTML version of .md original, we had to
install locally Pandoc v. 2.3.1 using make/devkit/createPandocBundle.sh,
configure with PANDOC=path-to-pandoc-executable flag
remove building.html
and make update-build-docs

New version has only necessary changes for Git transition, I think. See also a backport of JDK-8251549.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264823: Update building.html document for Git in jdk15u

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/19.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264823: Update building.html document for Git in jdk15u

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 6d6a0fe: 8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9)
  • 1fc6729: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
  • dc56503: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X
  • a44e891: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32
  • 5e89755: 8261198: [macOS] Incorrect JNI parameters in number conversion in A11Y code
  • 14e56d1: 8259585: [macos] Bad JNI lookup error : Accessible actions do not work on macOS
  • 847c0e3: 8259232: Bad JNI lookup during printing
  • 698dd44: 8262110: DST starts from incorrect time in 2038
  • ace2b56: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes
  • 44c196a: 8257414: Drag n Drop target area is wrong on high DPI systems
  • ... and 1 more: https://git.openjdk.java.net/jdk15u-dev/compare/6cf1c0dcdb1e09c64106ef56dc734903a07c0111...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 22, 2021
@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Apr 22, 2021

/integrate

@openjdk openjdk bot closed this Apr 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2021

@yan-too Since your change was applied there have been 11 commits pushed to the master branch:

  • 6d6a0fe: 8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9)
  • 1fc6729: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
  • dc56503: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X
  • a44e891: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32
  • 5e89755: 8261198: [macOS] Incorrect JNI parameters in number conversion in A11Y code
  • 14e56d1: 8259585: [macos] Bad JNI lookup error : Accessible actions do not work on macOS
  • 847c0e3: 8259232: Bad JNI lookup during printing
  • 698dd44: 8262110: DST starts from incorrect time in 2038
  • ace2b56: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes
  • 44c196a: 8257414: Drag n Drop target area is wrong on high DPI systems
  • ... and 1 more: https://git.openjdk.java.net/jdk15u-dev/compare/6cf1c0dcdb1e09c64106ef56dc734903a07c0111...master

Your commit was automatically rebased without conflicts.

Pushed as commit f35be84.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the yan-too:jdk8264823 branch May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants