Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8276657: XSLT compiler tries to define a class with empty name #195

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Apr 7, 2022

I'd like to backport JDK-8276657 to jdk15u for parity with jdk11u.
The original patch applied cleanly. It's simple and low risk.
The arguments sound reasonable https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-November/083135.html
All regular tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276657: XSLT compiler tries to define a class with empty name

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/195/head:pull/195
$ git checkout pull/195

Update a local copy of the PR:
$ git checkout pull/195
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 195

View PR using the GUI difftool:
$ git pr show -t 195

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/195.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2022

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a093cdddaf5ab88eb84a147e523db5c3e1be54be 8276657: XSLT compiler tries to define a class with empty name Apr 7, 2022
@openjdk
Copy link

openjdk bot commented Apr 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 7, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 7, 2022

Webrevs

Copy link
Collaborator

@yan-too yan-too left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skara doesn't mark it clean because of a LastModified difference

@openjdk
Copy link

openjdk bot commented Apr 8, 2022

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8276657: XSLT compiler tries to define a class with empty name

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 6e0cb9d: 8273655: content-types.properties files are missing some common types
  • 2d87380: 8193682: Infinite loop in ZipOutputStream.close()
  • 999f4d2: 8283350: (tz) Update Timezone Data to 2022a

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 8, 2022
@omikhaltsova
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 8, 2022

Going to push as commit 99453b0.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 6e0cb9d: 8273655: content-types.properties files are missing some common types
  • 2d87380: 8193682: Infinite loop in ZipOutputStream.close()
  • 999f4d2: 8283350: (tz) Update Timezone Data to 2022a

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2022
@openjdk openjdk bot closed this Apr 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 8, 2022
@openjdk
Copy link

openjdk bot commented Apr 8, 2022

@omikhaltsova Pushed as commit 99453b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants