Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported #199

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 25, 2022

I'd like to backport it to 15 where this issue exists, too. Applies perfectly barring a comma in copyright. All zipfs tests pass OK.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/199/head:pull/199
$ git checkout pull/199

Update a local copy of the PR:
$ git checkout pull/199
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 199

View PR using the GUI difftool:
$ git pr show -t 199

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/199.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 25, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 161fdb4afbc6e67cc7580fe753112c4d894a9b6b 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported Apr 25, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Apr 25, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 25, 2022

Webrevs

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Apr 25, 2022

lgtb

@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported

Reviewed-by: vkempik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 25, 2022
@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Apr 25, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2022

Going to push as commit 1d29a2f.

@openjdk openjdk bot added the integrated label Apr 25, 2022
@openjdk openjdk bot closed this Apr 25, 2022
@openjdk openjdk bot removed ready rfr labels Apr 25, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 25, 2022

@yan-too Pushed as commit 1d29a2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8273935 branch Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants