Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248552: C2 crashes with SIGFPE due to division by zero #20

Closed
wants to merge 1 commit into from

Conversation

@omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Apr 9, 2021

I'd like to backport JDK-8248552 to jdk15u for parity with jdk11u.
The original patch applied cleanly.
Tested with the test attached to the corresponding issue and the test added in this patch.
In addition tested with jtreg:test/hotspot/jtreg/compiler, no regression.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248552: C2 crashes with SIGFPE due to division by zero

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/20/head:pull/20
$ git checkout pull/20

Update a local copy of the PR:
$ git checkout pull/20
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/20/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20

View PR using the GUI difftool:
$ git pr show -t 20

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/20.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 9, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 417e8e449df569f593b82ecd640fa01b6b762832 8248552: C2 crashes with SIGFPE due to division by zero Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248552: C2 crashes with SIGFPE due to division by zero

Bail out in PhaseIdealLoop:split_thru_phi when trying to split a Div or ModNode iv phi whose zero check was removed but could potentially still be zero based on type information.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 9, 2021

Webrevs

@omikhaltsova
Copy link
Author

@omikhaltsova omikhaltsova commented Apr 9, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@omikhaltsova
Your change (at version 889c869) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 9, 2021

/sponsor

@openjdk openjdk bot closed this Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@yan-too @omikhaltsova Pushed as commit 7378892.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the omikhaltsova:backport-417e8e44 branch May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants