Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234 #206

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented May 6, 2022

I'd like to backport this useful fix to 15u, too. tier-tested on several platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/206/head:pull/206
$ git checkout pull/206

Update a local copy of the PR:
$ git checkout pull/206
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 206

View PR using the GUI difftool:
$ git pr show -t 206

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/206.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 6, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 712014c5956cf74982531d212b03460843e4e5b6 8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234 May 6, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels May 6, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 6, 2022

Webrevs

@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented May 6, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2022

Going to push as commit 41642f1.

@openjdk openjdk bot added the integrated label May 6, 2022
@openjdk openjdk bot closed this May 6, 2022
@openjdk openjdk bot removed ready rfr labels May 6, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2022

@yan-too Pushed as commit 41642f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8258077 branch May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant