Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head #208

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented May 12, 2022

This is a necessary unification patch.
Version from 17u applies without any difference. Tested so far with regtests of jdk/javax/xml/jaxp, jaxp/javax/xml (together with JDK-8285727 patch).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/208/head:pull/208
$ git checkout pull/208

Update a local copy of the PR:
$ git checkout pull/208
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 208

View PR using the GUI difftool:
$ git pr show -t 208

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/208.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 12, 2022
@mlbridge
Copy link

mlbridge bot commented May 12, 2022

Webrevs

bae
bae approved these changes May 12, 2022
@openjdk
Copy link

openjdk bot commented May 12, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 12, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented May 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 12, 2022

Going to push as commit 47b35cc.

@openjdk openjdk bot added the integrated label May 12, 2022
@openjdk openjdk bot closed this May 12, 2022
@openjdk openjdk bot removed ready rfr labels May 12, 2022
@openjdk
Copy link

openjdk bot commented May 12, 2022

@yan-too Pushed as commit 47b35cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8285726 branch May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants