Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers #210

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented May 13, 2022

Same issue with register corruption is present all the way back to 8u and causes builds to crash when using GCC 12.

Backport was mostly clean. Just the copyright header change needed to be adjusted.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/210/head:pull/210
$ git checkout pull/210

Update a local copy of the PR:
$ git checkout pull/210
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 210

View PR using the GUI difftool:
$ git pr show -t 210

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/210.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ecd85e6f0f8906ad1e8aa0a53bf499e8c969ba73 8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers May 13, 2022
@openjdk
Copy link

openjdk bot commented May 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 13, 2022
@mlbridge
Copy link

mlbridge bot commented May 13, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 23, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282231: x86-32: runtime call to SharedRuntime::ldiv corrupts registers

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 23, 2022
@yan-too
Copy link
Collaborator

yan-too commented Jun 6, 2022

Hi Andrew, please set the label jdk15u-fix-request! We still have some time to include this fix in July.

@gnu-andrew
Copy link
Member Author

Hi Andrew, please set the label jdk15u-fix-request! We still have some time to include this fix in July.

Done. Would you prefer jdk15u-critical-request to include it for July? I'm not sure of the process used for 13u & 15u in this regard.

@yan-too
Copy link
Collaborator

yan-too commented Jun 16, 2022

As to the request routines, usually we stop accepting non-critical changes one month before the release (and push criticals to master) -- but this time I'm afraid it will be even 20 days. There's no release numbers yet and vacations and java.net transition interfere.

@gnu-andrew
Copy link
Member Author

Ok, I don't see any reason to rush this into the release. I see jdk15u-fix-yes now so I'll integrate this into jdk15u-dev.

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2022

Going to push as commit 30d4810.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 916b139: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • 528e52f: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • f799c6a: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.
  • 8d35250: 8250863: Build error with GCC 10 in NetworkInterface.c and k_standard.c
  • ae4c633: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
  • 2cfbdff: 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value
  • 08e93a9: 8287109: Distrust.java failed with CertificateExpiredException
  • 08d0173: 8282583: Update BCEL md to include the copyright notice
  • f6ea4fa: 8255035: Update BCEL to Version 6.5.0
  • 087abc1: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
  • ... and 3 more: https://git.openjdk.org/jdk15u-dev/compare/9b074a7dcc7ed2a732cdad278c69c1484b7f668f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2022
@openjdk openjdk bot closed this Jun 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2022
@openjdk
Copy link

openjdk bot commented Jun 19, 2022

@gnu-andrew Pushed as commit 30d4810.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants