Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8285523: Improve test java/io/FileOutputStream/OpenNUL.java #211

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 15, 2022

Hi all,
This pull request contains a backport of commit f42631e3 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 29 Apr 2022 and was reviewed by Andrew John Hughes and Brian Burkhalter.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285523: Improve test java/io/FileOutputStream/OpenNUL.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/211/head:pull/211
$ git checkout pull/211

Update a local copy of the PR:
$ git checkout pull/211
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 211

View PR using the GUI difftool:
$ git pr show -t 211

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/211.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f42631e354d4abf7994abd92aa5def6b2ceeab3a 8285523: Improve test java/io/FileOutputStream/OpenNUL.java May 15, 2022
@openjdk
Copy link

openjdk bot commented May 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 15, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285523: Improve test java/io/FileOutputStream/OpenNUL.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 9b074a7: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
  • 47b35cc: 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head
  • be5bd9f: 8285686: Update FreeType to 2.12.0
  • 41642f1: 8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234
  • 957610f: 8252401: Introduce Utils.TEST_NATIVE_PATH

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 15, 2022
@mrserb mrserb marked this pull request as ready for review May 16, 2022 00:14
@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2022
@mlbridge
Copy link

mlbridge bot commented May 16, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented May 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2022

Going to push as commit 14a2da0.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 9b074a7: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
  • 47b35cc: 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head
  • be5bd9f: 8285686: Update FreeType to 2.12.0
  • 41642f1: 8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234
  • 957610f: 8252401: Introduce Utils.TEST_NATIVE_PATH

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2022
@openjdk openjdk bot closed this May 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

@mrserb Pushed as commit 14a2da0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant