Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value #218

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Jun 9, 2022

This fix should be backported here, too. The only difference with the original patch is in old copyright date.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/218/head:pull/218
$ git checkout pull/218

Update a local copy of the PR:
$ git checkout pull/218
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/218/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 218

View PR using the GUI difftool:
$ git pr show -t 218

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/218.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c96085eaab1f6b21e084b94fcc619d090f0afc97 8282929: Localized monetary symbols are not reflected in toLocalizedPattern return value Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 9, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jun 9, 2022

/clean

@openjdk openjdk bot added the clean label Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@yan-too This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2022

Webrevs

@yan-too
Copy link
Collaborator Author

yan-too commented Jun 9, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 9, 2022

Going to push as commit 2cfbdff.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 9, 2022
@openjdk openjdk bot closed this Jun 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@yan-too Pushed as commit 2cfbdff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8282929 branch June 9, 2022 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant