Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem #222

Closed
wants to merge 2 commits into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Jun 13, 2022

I'd like to backport JDK-8275703 to jdk15u in order to fix the same issue.
The patch applies almost cleanly except NativeLibraries.java due to the copyright year and the import section differences.
The issue was reproduced and verified locally on macOS Monterey 12.0.1 according to the guideline described in the bug. After applying this patch the issue was eliminated.
Tested with tier1 (macOS x64, Linux x64, Windows x64).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/222/head:pull/222
$ git checkout pull/222

Update a local copy of the PR:
$ git checkout pull/222
$ git pull https://git.openjdk.org/jdk15u-dev pull/222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 222

View PR using the GUI difftool:
$ git pr show -t 222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/222.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2022

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 309acbf0e86a0d248294503fccc7a936fa0a846e 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem Jun 13, 2022
@openjdk
Copy link

openjdk bot commented Jun 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 13, 2022
@omikhaltsova omikhaltsova marked this pull request as ready for review June 16, 2022 21:23
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 16, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2022

Webrevs

@VladimirKempik
Copy link

so, this is to load libraries which are not present on disk but present in dyld cache, right ?

Copy link

@VladimirKempik VladimirKempik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem

Reviewed-by: vkempik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 528e52f: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • f799c6a: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.
  • 8d35250: 8250863: Build error with GCC 10 in NetworkInterface.c and k_standard.c

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2022
@omikhaltsova
Copy link
Author

exactly, the fix is for macOS 11+, for libraries loaded from the dynamic linker cache.

@omikhaltsova
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2022

Going to push as commit 916b139.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 528e52f: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • f799c6a: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.
  • 8d35250: 8250863: Build error with GCC 10 in NetworkInterface.c and k_standard.c

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 17, 2022
@openjdk openjdk bot closed this Jun 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2022
@openjdk
Copy link

openjdk bot commented Jun 17, 2022

@omikhaltsova Pushed as commit 916b139.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants