Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8262110: DST starts from incorrect time in 2038 #23

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 14, 2021

Fix is surprisingly small, the patch applies without shifts, regtest do pass


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8262110: DST starts from incorrect time in 2038
  • JDK-8073446: TimeZone getOffset API does not return a dst offset between years 2038-2137

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/23/head:pull/23
$ git checkout pull/23

Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/23/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23

View PR using the GUI difftool:
$ git pr show -t 23

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/23.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7284f013ea3064b2aa643658938ccaafdfa1c885 8262110: DST starts from incorrect time in 2038 Apr 14, 2021
@openjdk
Copy link

openjdk bot commented Apr 14, 2021

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 14, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8262110: DST starts from incorrect time in 2038
8073446: TimeZone getOffset API does not  return a dst offset between years 2038-2137

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ace2b56: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes
  • 44c196a: 8257414: Drag n Drop target area is wrong on high DPI systems
  • 7378892: 8248552: C2 crashes with SIGFPE due to division by zero

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 14, 2021
@yan-too
Copy link
Collaborator Author

yan-too commented Apr 14, 2021

/integrate

@openjdk openjdk bot closed this Apr 14, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 14, 2021
@openjdk
Copy link

openjdk bot commented Apr 14, 2021

@yan-too Since your change was applied there have been 3 commits pushed to the master branch:

  • ace2b56: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes
  • 44c196a: 8257414: Drag n Drop target area is wrong on high DPI systems
  • 7378892: 8248552: C2 crashes with SIGFPE due to division by zero

Your commit was automatically rebased without conflicts.

Pushed as commit 698dd44.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Apr 14, 2021

Webrevs

@yan-too yan-too deleted the dst8262110 branch April 20, 2021 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant