Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8281628: KeyAgreement : generateSecret intermittently not resetting #230

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Jul 13, 2022

Small ad-hoc change in the test made to avoid HexFormat.
All crypto tests do pass, including a new one.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281628: KeyAgreement : generateSecret intermittently not resetting

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/230/head:pull/230
$ git checkout pull/230

Update a local copy of the PR:
$ git checkout pull/230
$ git pull https://git.openjdk.org/jdk15u-dev pull/230/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 230

View PR using the GUI difftool:
$ git pr show -t 230

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/230.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1485883c9e6e24315bb21f20604b1c326e862a5b 8281628: KeyAgreement : generateSecret intermittently not resetting Jul 13, 2022
@openjdk
Copy link

openjdk bot commented Jul 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8281628: KeyAgreement : generateSecret intermittently not resetting

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 13, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jul 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@yan-too An unexpected error occurred during integration. No push attempt will be made. The error has been logged and will be investigated. It is possible that this error is caused by a transient issue; feel free to retry the operation.

@yan-too
Copy link
Collaborator Author

yan-too commented Jul 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 14, 2022

Going to push as commit 0dee7da.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 14, 2022
@openjdk openjdk bot closed this Jul 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@yan-too Pushed as commit 0dee7da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8281628 branch July 14, 2022 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants