Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Jul 26, 2022

Backport of 8256372 is a necessary pre- (in my case, alas, post) requisite to HarfBuzz update.
Original patch required resolution of two conflicts in the context and change in FontUtilities logInfo() to getLogger().info() but apparently nothing important.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/240/head:pull/240
$ git checkout pull/240

Update a local copy of the PR:
$ git checkout pull/240
$ git pull https://git.openjdk.org/jdk15u-dev pull/240/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 240

View PR using the GUI difftool:
$ git pr show -t 240

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/240.diff

@yan-too yan-too changed the title Hb8256372 Backport 005d8a7fca8b4d9519d2bde0a7cdbbece1cd3981 Jul 26, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 005d8a7fca8b4d9519d2bde0a7cdbbece1cd3981 8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 26, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 26, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jul 26, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 26, 2022

Going to push as commit b1b3260.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 26, 2022
@openjdk openjdk bot closed this Jul 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@yan-too Pushed as commit b1b3260.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the hb8256372 branch July 26, 2022 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants