Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8264792: The NumberFormat for locale sq_XK formats price incorrectly. #248

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Jul 29, 2022

backporting for parity with major releases.
Tests for currency all pass after the fix.
A list of covered fixes in ValidateISO4217.java slightly differs in 15u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8264792: The NumberFormat for locale sq_XK formats price incorrectly.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/248/head:pull/248
$ git checkout pull/248

Update a local copy of the PR:
$ git checkout pull/248
$ git pull https://git.openjdk.org/jdk15u-dev pull/248/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 248

View PR using the GUI difftool:
$ git pr show -t 248

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/248.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 41dc795d6c08af84aa6544cc5a5704dcf99386cf 8264792: The NumberFormat for locale sq_XK formats price incorrectly. Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 29, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2022

Webrevs

@yan-too
Copy link
Collaborator Author

yan-too commented Jul 29, 2022

/clean

@openjdk openjdk bot added the clean label Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@yan-too This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264792: The NumberFormat for locale sq_XK formats price incorrectly.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 29, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jul 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 29, 2022

Going to push as commit b3aec28.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 29, 2022
@openjdk openjdk bot closed this Jul 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@yan-too Pushed as commit b3aec28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8264792 branch July 29, 2022 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant