Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8268361: Fix the infinite loop in next_line #260

Closed
wants to merge 1 commit into from

Conversation

wkia
Copy link

@wkia wkia commented Aug 26, 2022

Backport of JDK-8268361 to 15u.
It needs to be ported due to similar problems as 17u has.
Fix applies cleanly. Tests tier1 passed after the fix without regression.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/260/head:pull/260
$ git checkout pull/260

Update a local copy of the PR:
$ git checkout pull/260
$ git pull https://git.openjdk.org/jdk15u-dev pull/260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 260

View PR using the GUI difftool:
$ git pr show -t 260

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/260.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Aug 26, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2022

Hi @wkia, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user wkia" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk openjdk bot changed the title Backport 72672277e4dddf8e72f1c705cd5f57de40745635 8268361: Fix the infinite loop in next_line Aug 26, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

This backport pull request has now been updated with issue from the original commit.

@wkia
Copy link
Author

wkia commented Aug 26, 2022

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Aug 26, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@robilad
Copy link

robilad commented Aug 28, 2022

Hi, please send an e-Mail to Dalibor.topic@oracle.com so that I can verify your account.

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Aug 30, 2022
@openjdk
Copy link

openjdk bot commented Aug 30, 2022

@wkia This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268361: Fix the infinite loop in next_line

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 899d5f8: 8287463: JFR: Disable TestDevNull.java on Windows
  • 68f09d4: 8282947: JFR: Dump on shutdown live-locks in some conditions
  • e7fdc3a: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • 03bf615: 7131823: bug in GIFImageReader

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2022

Webrevs

@wkia
Copy link
Author

wkia commented Aug 31, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 31, 2022
@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@wkia
Your change (at version b989e1d) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Aug 31, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

Going to push as commit 8392a31.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 899d5f8: 8287463: JFR: Disable TestDevNull.java on Windows
  • 68f09d4: 8282947: JFR: Dump on shutdown live-locks in some conditions
  • e7fdc3a: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • 03bf615: 7131823: bug in GIFImageReader

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2022
@openjdk openjdk bot closed this Aug 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 31, 2022
@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@yan-too @wkia Pushed as commit 8392a31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wkia wkia deleted the backport-72672277 branch August 31, 2022 09:07
@wkia wkia restored the backport-72672277 branch August 31, 2022 09:07
@wkia wkia deleted the backport-72672277 branch August 31, 2022 09:20
@wkia wkia restored the backport-72672277 branch August 31, 2022 09:21
@wkia wkia deleted the backport-72672277 branch August 31, 2022 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants