8253353: Crash in C2: guarantee(n != NULL) failed: No Node

[omikhaltsova]

I'd like to backport JDK-8253353 to jdk15u for parity with jdk11u. The original patch applies cleanly (see 1st commit).
In spite of simplicity and low risk it contains a bug that was fixed under JDK-8260632.
The backport for 8260632: Build failures after JDK-8253353 was included as a part of this patch due to dependency. It applies also cleanly (see 2nd commit).
Tested with tier1-3 on Linux x64, Windows x64, macOS x64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8253353: Crash in C2: guarantee(n != NULL) failed: No Node
• JDK-8260632: Build failures after JDK-8253353

Reviewers

• Yuri Nesterenko (@yan-too - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/263/head:pull/263
$ git checkout pull/263

Update a local copy of the PR:
$ git checkout pull/263
$ git pull https://git.openjdk.org/jdk15u-dev pull/263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 263

View PR using the GUI difftool:
$ git pr show -t 263

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/263.diff

[bridgekeeper]

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[omikhaltsova]

/issue add JDK-8260632

[openjdk]

@omikhaltsova
Adding additional issue to issue list: 8260632: Build failures after JDK-8253353.

[mlbridge]

Webrevs

• 00: Full (07cd1a67)

[openjdk]

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253353: Crash in C2: guarantee(n != NULL) failed: No Node
8260632: Build failures after JDK-8253353

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 6f169cb: 8207936: TestZipFile failed with java.lang.AssertionError exception
• fa427af: 8287162: (zipfs) Performance regression related to support for POSIX file permissions
• 8392a31: 8268361: Fix the infinite loop in next_line
• 899d5f8: 8287463: JFR: Disable TestDevNull.java on Windows
• 68f09d4: 8282947: JFR: Dump on shutdown live-locks in some conditions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[omikhaltsova]

/integrate

[openjdk]

Going to push as commit 5964d52.
Since your change was applied there have been 5 commits pushed to the master branch:

• 6f169cb: 8207936: TestZipFile failed with java.lang.AssertionError exception
• fa427af: 8287162: (zipfs) Performance regression related to support for POSIX file permissions
• 8392a31: 8268361: Fix the infinite loop in next_line
• 899d5f8: 8287463: JFR: Disable TestDevNull.java on Windows
• 68f09d4: 8282947: JFR: Dump on shutdown live-locks in some conditions

Your commit was automatically rebased without conflicts.

[openjdk]

@omikhaltsova Pushed as commit 5964d52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.