Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8287162: (zipfs) Performance regression related to support for POSIX file permissions #265

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Aug 31, 2022

This fix should be ported here, too, to be on par with later releases.
All test/jdk/java/util/zip test/jdk/jdk/nio/zipfs tests pass but one: jdk/java/util/zip/ZipFile/TestZipFile.java should be updated with 8207936 (there's no getMetaInfEntryNames() in ZipFile.java in 15u)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287162: (zipfs) Performance regression related to support for POSIX file permissions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/265/head:pull/265
$ git checkout pull/265

Update a local copy of the PR:
$ git checkout pull/265
$ git pull https://git.openjdk.org/jdk15u-dev pull/265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 265

View PR using the GUI difftool:
$ git pr show -t 265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/265.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a10c5597d93c4402bafdbb570437aac052b10027 8287162: (zipfs) Performance regression related to support for POSIX file permissions Aug 31, 2022
@openjdk
Copy link

openjdk bot commented Aug 31, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287162: (zipfs) Performance regression related to support for POSIX file permissions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 8392a31: 8268361: Fix the infinite loop in next_line
  • 899d5f8: 8287463: JFR: Disable TestDevNull.java on Windows
  • 68f09d4: 8282947: JFR: Dump on shutdown live-locks in some conditions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 31, 2022

Webrevs

@yan-too
Copy link
Collaborator Author

yan-too commented Aug 31, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

Going to push as commit fa427af.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 8392a31: 8268361: Fix the infinite loop in next_line
  • 899d5f8: 8287463: JFR: Disable TestDevNull.java on Windows
  • 68f09d4: 8282947: JFR: Dump on shutdown live-locks in some conditions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2022
@openjdk openjdk bot closed this Aug 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2022
@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@yan-too Pushed as commit fa427af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8287162 branch August 31, 2022 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant