Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998 #267

Closed
wants to merge 1 commit into from

Conversation

Larry-N
Copy link
Contributor

@Larry-N Larry-N commented Sep 2, 2022

Tested with tier-1 on Mac OS x86_64


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/267/head:pull/267
$ git checkout pull/267

Update a local copy of the PR:
$ git checkout pull/267
$ git pull https://git.openjdk.org/jdk15u-dev pull/267/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 267

View PR using the GUI difftool:
$ git pr show -t 267

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/267.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2022

👋 Welcome back inakonechnyy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c16d1fc9810d5b2c112d35f3298513f86f84f66d 8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998 Sep 2, 2022
@openjdk
Copy link

openjdk bot commented Sep 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 2, 2022

@Larry-N This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5964d52: 8253353: Crash in C2: guarantee(n != NULL) failed: No Node

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 2, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2022

Webrevs

@Larry-N
Copy link
Contributor Author

Larry-N commented Sep 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 12, 2022

Going to push as commit 5e52b38.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 008266b: 8257467: [TESTBUG] -Wdeprecated-declarations is reported at sigset() in exesigtest.c
  • bc76057: 8272472: StackGuardPages test doesn't build with glibc 2.34
  • e2ac050: 8276841: Add support for Visual Studio 2022
  • bcc79e2: 8247818: GCC 10 warning stringop-overflow with symbol code
  • 753becc: 8252051: Make mlvmJvmtiUtils strncpy uses GCC 10.x friendly
  • 1daf5c5: 8293354: fastdebug build broken after JDK-8281866
  • 5964d52: 8253353: Crash in C2: guarantee(n != NULL) failed: No Node

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 12, 2022
@openjdk openjdk bot closed this Sep 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 12, 2022
@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@Larry-N Pushed as commit 5e52b38.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant