Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8028265: Add legacy tz tests to OpenJDK #276

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Sep 13, 2022

I'd like to backport the change here to make easier later backports such as 2022c tz etc. -- and to have these timezone tests
They do pass for the current state of data.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/276/head:pull/276
$ git checkout pull/276

Update a local copy of the PR:
$ git checkout pull/276
$ git pull https://git.openjdk.org/jdk15u-dev pull/276/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 276

View PR using the GUI difftool:
$ git pr show -t 276

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/276.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 92deab546549ca549408a983fe361d9536d2cd37 8028265: Add legacy tz tests to OpenJDK Sep 13, 2022
@openjdk
Copy link

openjdk bot commented Sep 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 13, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8028265: Add legacy tz tests to OpenJDK

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5e52b38: 8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2022

Webrevs

@yan-too
Copy link
Collaborator Author

yan-too commented Sep 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2022

Going to push as commit 2d0ace5.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 5e52b38: 8269285: Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2022
@openjdk openjdk bot closed this Sep 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2022
@openjdk
Copy link

openjdk bot commented Sep 13, 2022

@yan-too Pushed as commit 2d0ace5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8028265 branch September 13, 2022 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant