Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint #282

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Sep 19, 2022

Hi! Here is backport of JDK-8266082 that fixes javac crash on unallowed annotation usage when running with -Xdoclint option. Original patch applied cleanly

Verification (amd64/20.04LTS): tools/doclint/CrashInAnnotateTest.java (new test)
Regression(amd64/20.04LTS): test/langtools


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/282/head:pull/282
$ git checkout pull/282

Update a local copy of the PR:
$ git checkout pull/282
$ git pull https://git.openjdk.org/jdk15u-dev pull/282/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 282

View PR using the GUI difftool:
$ git pr show -t 282

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/282.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0b8a0e2b58dbdd5c9553e502212d32c033a5efb5 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint Sep 19, 2022
@openjdk
Copy link

openjdk bot commented Sep 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 19, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 21f57b4: 8266172: -Wstringop-overflow happens in vmError.cpp
  • 0938ea8: 8266170: -Wnonnull happens in classLoaderData.inline.hpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 19, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2022

Webrevs

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 19, 2022
@openjdk
Copy link

openjdk bot commented Sep 19, 2022

@apavlyutkin
Your change (at version 20fe748) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Sep 19, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 19, 2022

Going to push as commit 7647ac5.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 21f57b4: 8266172: -Wstringop-overflow happens in vmError.cpp
  • 0938ea8: 8266170: -Wnonnull happens in classLoaderData.inline.hpp

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 19, 2022
@openjdk openjdk bot closed this Sep 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 19, 2022
@openjdk
Copy link

openjdk bot commented Sep 19, 2022

@yan-too @apavlyutkin Pushed as commit 7647ac5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants