Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8292158: AES-CTR cipher state corruption with AVX-512 #290

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Oct 21, 2022

The issue fixed here is introduced in 2019 in jdk14 so it should present in 15, too. The code part is similar to that in 17u backport version, in the test I have to change one line mentioning ClassFileInstaller as necessary. Sanity-tested with hotspot/jtreg/compiler tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292158: AES-CTR cipher state corruption with AVX-512

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/290/head:pull/290
$ git checkout pull/290

Update a local copy of the PR:
$ git checkout pull/290
$ git pull https://git.openjdk.org/jdk15u-dev pull/290/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 290

View PR using the GUI difftool:
$ git pr show -t 290

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/290.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9d76ac8a4453bc51d9dca2ad6c60259cfb2c4203 8292158: AES-CTR cipher state corruption with AVX-512 Oct 21, 2022
@openjdk
Copy link

openjdk bot commented Oct 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 21, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 21, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8292158: AES-CTR cipher state corruption with AVX-512

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Oct 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 21, 2022

Going to push as commit 8781ccc.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 21, 2022
@openjdk openjdk bot closed this Oct 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2022
@openjdk
Copy link

openjdk bot commented Oct 21, 2022

@yan-too Pushed as commit 8781ccc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8292158 branch October 21, 2022 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants