Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257242: [macOS] Java app crashes while switching input methods #32

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter
Filter file types
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.

Always

Just for now

@@ -37,9 +37,6 @@

// TODO: NSMenu *contextualMenu;

// Keyboard layout
NSString *kbdLayout;

// dnd support (see AppKit/NSDragging.h, NSDraggingSource/Destination):
CDragSource *_dragSource;
CDropTarget *_dropTarget;
@@ -37,6 +37,9 @@

#import <Carbon/Carbon.h>

// keyboard layout
static NSString *kbdLayout;

@interface AWTView()
@property (retain) CDropTarget *_dropTarget;
@property (retain) CDragSource *_dragSource;
@@ -1010,7 +1013,7 @@ - (void) insertText:(id)aString replacementRange:(NSRange)replacementRange
[self abandonInput];
}

- (void)keyboardInputSourceChanged:(NSNotification *)notification
+ (void)keyboardInputSourceChanged:(NSNotification *)notification
{
#ifdef IM_DEBUG
NSLog(@"keyboardInputSourceChangeNotification received");
@@ -1327,7 +1330,7 @@ - (NSUInteger)characterIndexForPoint:(NSPoint)thePoint
CHECK_EXCEPTION();

#ifdef IM_DEBUG
fprintf(stderr, "characterIndexForPoint returning %ld\n", index);
fprintf(stderr, "characterIndexForPoint returning %d\n", index);
#endif // IM_DEBUG

if (index == -1) {
ProTip! Use n and p to navigate between commits in a pull request.