Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256751: Incremental rebuild with precompiled header fails when touching a header file #34

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 26, 2021

Let's try to file this PR after (not yet integrated) PR for its right successor 8256810: hope it works. All patches apply clean, in the right order.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256751: Incremental rebuild with precompiled header fails when touching a header file

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/34/head:pull/34
$ git checkout pull/34

Update a local copy of the PR:
$ git checkout pull/34
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/34/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 34

View PR using the GUI difftool:
$ git pr show -t 34

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/34.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 19b2898691f945f0d6257e88ec74e291d5d7f277 8256751: Incremental rebuild with precompiled header fails when touching a header file Apr 26, 2021
@openjdk
Copy link

openjdk bot commented Apr 26, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256751: Incremental rebuild with precompiled header fails when touching a header file

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2021
@yan-too
Copy link
Collaborator Author

yan-too commented Apr 26, 2021

/integrate

@openjdk openjdk bot closed this Apr 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2021
@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@yan-too Pushed as commit 70230e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Apr 26, 2021

Webrevs

@yan-too yan-too deleted the bld825675 branch Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant