Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256633: Fix product build on Windows+Arm64 #38

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Apr 26, 2021

Clean backport of 8256633 to jdk15.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/38/head:pull/38
$ git checkout pull/38

Update a local copy of the PR:
$ git checkout pull/38
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/38/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 38

View PR using the GUI difftool:
$ git pr show -t 38

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/38.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f57662874afe03250050b88ced07eb480484802b 8256633: Fix product build on Windows+Arm64 Apr 26, 2021
@openjdk
Copy link

openjdk bot commented Apr 26, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 26, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256633: Fix product build on Windows+Arm64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 981267e: 8257633: Missing -mmacosx-version-min=X flag when linking libjvm
  • a92bbe8: 8257547: Handle multiple prereqs on the same line in deps files

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Apr 26, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2021

Webrevs

@VladimirKempik
Copy link
Author

VladimirKempik commented Apr 27, 2021

/integrate

@openjdk openjdk bot closed this Apr 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 27, 2021
@openjdk
Copy link

openjdk bot commented Apr 27, 2021

@VladimirKempik Since your change was applied there have been 2 commits pushed to the master branch:

  • 981267e: 8257633: Missing -mmacosx-version-min=X flag when linking libjvm
  • a92bbe8: 8257547: Handle multiple prereqs on the same line in deps files

Your commit was automatically rebased without conflicts.

Pushed as commit 9b0ba2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the backport-f57662874afe03250050b88ced07eb480484802b branch Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant