Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93) #48

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented May 11, 2021

I would like to backport JDK-8241248 to 15u
The patch applied clean
sun/security/ssl and javax/net/ssl tests passed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/48/head:pull/48
$ git checkout pull/48

Update a local copy of the PR:
$ git checkout pull/48
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/48/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 48

View PR using the GUI difftool:
$ git pr show -t 48

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/48.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2021

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1603ca23422b03157afb2bd1050524465474b60e 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93) May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 11, 2021

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fb51322: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
  • ca0a09e: 8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 11, 2021
@mlbridge
Copy link

mlbridge bot commented May 11, 2021

Webrevs

@alexeybakhtin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@alexeybakhtin
Your change (at version 94d4de0) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented May 11, 2021

/sponsor

@openjdk openjdk bot closed this May 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@yan-too @alexeybakhtin Since your change was applied there have been 2 commits pushed to the master branch:

  • fb51322: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
  • ca0a09e: 8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics

Your commit was automatically rebased without conflicts.

Pushed as commit 2486d30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants