Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 swap limit capabilities #50

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link

@kvergizova kvergizova commented May 11, 2021

I'd like to backport JDK-8250984 to 15u for parity with 11u.
The patch applies almost cleanly except for changes in ProblemLists, they are skipped as not applicable to 15u.
Tested with tier1 and container tests.
Follow-up fix JDK-8257746 is planned to be backported as well.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 swap limit capabilities

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/50/head:pull/50
$ git checkout pull/50

Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/50/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 50

View PR using the GUI difftool:
$ git pr show -t 50

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/50.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0187567704d79ecf394d4cb656d0ba4c886351f1 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 swap limit capabilities May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 11, 2021
@mlbridge
Copy link

mlbridge bot commented May 11, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented May 12, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 swap limit capabilities

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 12, 2021
@kvergizova
Copy link
Author

/integrate

@openjdk openjdk bot closed this May 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2021
@openjdk
Copy link

openjdk bot commented May 13, 2021

@kvergizova Since your change was applied there has been 1 commit pushed to the master branch:

  • 631defc: 8264821: DirectIOTest fails on a system with large block size

Your commit was automatically rebased without conflicts.

Pushed as commit 4d0f905.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8250984 branch May 13, 2021 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants