Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264821: DirectIOTest fails on a system with large block size #51

Closed
wants to merge 1 commit into from

Conversation

@snazarkin
Copy link
Contributor

@snazarkin snazarkin commented May 12, 2021

I'd like to backport this fix for parity with jdk17/13/11. The patch applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264821: DirectIOTest fails on a system with large block size

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/51/head:pull/51
$ git checkout pull/51

Update a local copy of the PR:
$ git checkout pull/51
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/51/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 51

View PR using the GUI difftool:
$ git pr show -t 51

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/51.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 12, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7e4cd480206891550828d1fdfebae57ecc19ed37 8264821: DirectIOTest fails on a system with large block size May 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264821: DirectIOTest fails on a system with large block size

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 12, 2021

Webrevs

@snazarkin
Copy link
Contributor Author

@snazarkin snazarkin commented May 12, 2021

/integrate

@openjdk openjdk bot added the sponsor label May 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@snazarkin
Your change (at version d1dc2e7) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented May 13, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented May 13, 2021

@yan-too @snazarkin Pushed as commit 631defc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the backport-8264821 branch Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants