Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263361: Incorrect arraycopy stub selected by C2 for SATB collectors #52

Closed
wants to merge 1 commit into from

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented May 12, 2021

Hi!
I'd like to backport this patch that fixes hotspot debug builds crash. The patch doesn't apply cleanly due to miss of 8252848. The manual fix is required for macroArrayCopy.cpp:553: rename dest_uninitialized to acopy_to_uninitialized

Pass tier(1,2}


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263361: Incorrect arraycopy stub selected by C2 for SATB collectors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/52/head:pull/52
$ git checkout pull/52

Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/52/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 52

View PR using the GUI difftool:
$ git pr show -t 52

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/52.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 12, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5d87a21991b964e1c50495dc2dc982db425830b5 8263361: Incorrect arraycopy stub selected by C2 for SATB collectors May 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels May 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 12, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263361: Incorrect arraycopy stub selected by C2 for SATB collectors

Reviewed-by: vkempik, yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • e266324: 8252883: AccessDeniedException caused by delayed file deletion on Windows
  • 0f9e11c: 8251456: [TESTBUG] compiler/vectorization/TestVectorsNotSavedAtSafepoint.java failed OutOfMemoryError
  • a0b1ba1: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash
  • 0903e10: 8261395: C1 crash "cannot make java calls from the native compiler"
  • 717506c: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files
  • 2a1129e: 8261022: Fix incorrect result of Math.abs() with char type
  • 31a8f04: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • 14df120: 8256809: Annotation processing causes NPE during flow analysis
  • 723da96: 8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM
  • fb53967: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem
  • ... and 6 more: https://git.openjdk.java.net/jdk15u-dev/compare/d13fb263ff83feba616c269dfd6db174a4567496...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@VladimirKempik, @yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label May 26, 2021
@snazarkin
Copy link
Contributor Author

@snazarkin snazarkin commented May 27, 2021

/integrate

@openjdk openjdk bot added the sponsor label May 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2021

@snazarkin
Your change (at version 4a48565) is now ready to be sponsored by a Committer.

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented May 27, 2021

/sponsor

@openjdk openjdk bot closed this May 27, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels May 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2021

@VladimirKempik @snazarkin Since your change was applied there have been 16 commits pushed to the master branch:

  • e266324: 8252883: AccessDeniedException caused by delayed file deletion on Windows
  • 0f9e11c: 8251456: [TESTBUG] compiler/vectorization/TestVectorsNotSavedAtSafepoint.java failed OutOfMemoryError
  • a0b1ba1: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash
  • 0903e10: 8261395: C1 crash "cannot make java calls from the native compiler"
  • 717506c: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files
  • 2a1129e: 8261022: Fix incorrect result of Math.abs() with char type
  • 31a8f04: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • 14df120: 8256809: Annotation processing causes NPE during flow analysis
  • 723da96: 8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM
  • fb53967: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem
  • ... and 6 more: https://git.openjdk.java.net/jdk15u-dev/compare/d13fb263ff83feba616c269dfd6db174a4567496...master

Your commit was automatically rebased without conflicts.

Pushed as commit ebaf7e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the backport-8263361 branch Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants