Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257746: Regression introduced with JDK-8250984 - memory might be null in some machines #54

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link

@kvergizova kvergizova commented May 13, 2021

I'd like to backport JDK-8257746 to 15u as follow-up fix for JDK-8250984 that is already included to 15u.
The patch applies cleanly.
Tested with tier1 and container tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/54/head:pull/54
$ git checkout pull/54

Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/54/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 54

View PR using the GUI difftool:
$ git pr show -t 54

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/54.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 13, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport abc4300de9c7a298c359fb585d3b0570a98df5cb 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines May 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 13, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented May 13, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 22d0aab: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 13, 2021

Webrevs

@kvergizova
Copy link
Author

@kvergizova kvergizova commented May 13, 2021

/integrate

@openjdk openjdk bot closed this May 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 13, 2021

@kvergizova Since your change was applied there has been 1 commit pushed to the master branch:

  • 22d0aab: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29

Your commit was automatically rebased without conflicts.

Pushed as commit 0be19d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8257746 branch May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant