Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249608: Vector register used by C2 compiled method corrupted at safepoint #56

Closed
wants to merge 1 commit into from

Conversation

@omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented May 16, 2021

I'd like to backport JDK-8249608 to jdk15u for parity with jdk11u.
The original patch applied cleanly.
Tested with tier1, tier2.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249608: Vector register used by C2 compiled method corrupted at safepoint

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/56/head:pull/56
$ git checkout pull/56

Update a local copy of the PR:
$ git checkout pull/56
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/56/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 56

View PR using the GUI difftool:
$ git pr show -t 56

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/56.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 16, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 970e251a54d3b8871d3b948c1632c124f248cb01 8249608: Vector register used by C2 compiled method corrupted at safepoint May 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 16, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented May 16, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249608: Vector register used by C2 compiled method corrupted at safepoint

Always update 'max_vlen_in_bytes'.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • 30458d4: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows.
  • 0be19d2: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines
  • 22d0aab: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29
  • 4d0f905: 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 swap limit capabilities
  • 631defc: 8264821: DirectIOTest fails on a system with large block size
  • d13fb26: 8255880: UI of Swing components is not redrawn after their internal state changed
  • daa195a: 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap limit capabilities
  • 2486d30: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • fb51322: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
  • ca0a09e: 8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics
  • ... and 30 more: https://git.openjdk.java.net/jdk15u-dev/compare/a44e891d6ab07e25ef3b3b3eab3e31c73e31d94c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 16, 2021

Webrevs

@omikhaltsova
Copy link
Author

@omikhaltsova omikhaltsova commented May 17, 2021

/integrate

@openjdk openjdk bot added the sponsor label May 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@omikhaltsova
Your change (at version 97cb59c) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented May 17, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@yan-too @omikhaltsova Since your change was applied there have been 40 commits pushed to the master branch:

  • 30458d4: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows.
  • 0be19d2: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines
  • 22d0aab: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29
  • 4d0f905: 8250984: Memory Docker tests fail on some Linux kernels w/o cgroupv1 swap limit capabilities
  • 631defc: 8264821: DirectIOTest fails on a system with large block size
  • d13fb26: 8255880: UI of Swing components is not redrawn after their internal state changed
  • daa195a: 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap limit capabilities
  • 2486d30: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • fb51322: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
  • ca0a09e: 8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics
  • ... and 30 more: https://git.openjdk.java.net/jdk15u-dev/compare/a44e891d6ab07e25ef3b3b3eab3e31c73e31d94c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 73ab669.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the backport-970e251a branch May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants