Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM #58

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link

@kvergizova kvergizova commented May 17, 2021

I'd like to backport JDK-8251257 to 15u for parity with 11u.
The patch applies cleanly.
Tested with tier1 and nmt tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/58/head:pull/58
$ git checkout pull/58

Update a local copy of the PR:
$ git checkout pull/58
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/58/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 58

View PR using the GUI difftool:
$ git pr show -t 58

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/58.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6df465de7309e90bc4de8da66c7059035ffc9bef 8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM May 17, 2021
@openjdk
Copy link

openjdk bot commented May 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 17, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fb53967: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem
  • 73ab669: 8249608: Vector register used by C2 compiled method corrupted at safepoint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2021
@mlbridge
Copy link

mlbridge bot commented May 17, 2021

Webrevs

@kvergizova
Copy link
Author

/integrate

@openjdk openjdk bot closed this May 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2021
@openjdk
Copy link

openjdk bot commented May 17, 2021

@kvergizova Since your change was applied there have been 2 commits pushed to the master branch:

  • fb53967: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem
  • 73ab669: 8249608: Vector register used by C2 compiled method corrupted at safepoint

Your commit was automatically rebased without conflicts.

Pushed as commit 723da96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8251257 branch May 17, 2021 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant