Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8256501: libTestMainKeyWindow fails to build with Xcode 12.2 #6

Closed
wants to merge 1 commit into from
Closed

8256501: libTestMainKeyWindow fails to build with Xcode 12.2 #6

wants to merge 1 commit into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Apr 2, 2021

Backport-of: 4e5116c46e29977cccbe8c04cb5559ce345fa72e

A very simple and safe fix, a prerequest for JNF removal to apply more cleanly.
JavaVM is a pseudo framework for a long time already, linking with it has no meaning.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256501: libTestMainKeyWindow fails to build with Xcode 12.2

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/6.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4e5116c46e29977cccbe8c04cb5559ce345fa72e 8256501: libTestMainKeyWindow fails to build with Xcode 12.2 Apr 2, 2021
@openjdk
Copy link

openjdk bot commented Apr 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256501: libTestMainKeyWindow fails to build with Xcode 12.2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2021

Webrevs

@VladimirKempik
Copy link
Author

/integrate

@openjdk openjdk bot closed this Apr 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2021
@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@VladimirKempik Pushed as commit c565a2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the backport-4e5116c46e29977cccbe8c04cb5559ce345fa72e branch April 2, 2021 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant