Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8261022: Fix incorrect result of Math.abs() with char type #60

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link

@kvergizova kvergizova commented May 18, 2021

I'd like to backport JDK-8261022 to 15u for parity with 11u.
The patch applies cleanly, but requires a modification due to absence of VectorNode::is_shift_opcode in 15u (JDK-8257625 is not in 15u), replaced by similar VectorNode::is_shift.
Tested with tier1; new test fails without the patch, passes with it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261022: Fix incorrect result of Math.abs() with char type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/60/head:pull/60
$ git checkout pull/60

Update a local copy of the PR:
$ git checkout pull/60
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/60/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 60

View PR using the GUI difftool:
$ git pr show -t 60

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/60.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 18, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7a2db858e0e81f2ba17c3554386bb6a833318b3d 8261022: Fix incorrect result of Math.abs() with char type May 18, 2021
@openjdk
Copy link

openjdk bot commented May 18, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 18, 2021
@mlbridge
Copy link

mlbridge bot commented May 18, 2021

Webrevs

Copy link
Collaborator

@yan-too yan-too left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me: in 11 the change is about the same

@openjdk
Copy link

openjdk bot commented May 18, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261022: Fix incorrect result of Math.abs() with char type

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 14df120: 8256809: Annotation processing causes NPE during flow analysis

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 18, 2021
@kvergizova
Copy link
Author

/integrate

@openjdk openjdk bot closed this May 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 19, 2021
@openjdk
Copy link

openjdk bot commented May 19, 2021

@kvergizova Since your change was applied there have been 2 commits pushed to the master branch:

  • 31a8f04: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • 14df120: 8256809: Annotation processing causes NPE during flow analysis

Your commit was automatically rebased without conflicts.

Pushed as commit 2a1129e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8261022 branch May 19, 2021 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants