Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files #62

Closed
wants to merge 1 commit into from

Conversation

@dimitryc
Copy link
Collaborator

@dimitryc dimitryc commented May 19, 2021

8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/62/head:pull/62
$ git checkout pull/62

Update a local copy of the PR:
$ git checkout pull/62
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/62/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 62

View PR using the GUI difftool:
$ git pr show -t 62

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/62.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 19, 2021

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 7d8985243d472db19dd416a5d9fe116737d3b327 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@dimitryc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 2a1129e: 8261022: Fix incorrect result of Math.abs() with char type
  • 31a8f04: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • 14df120: 8256809: Annotation processing causes NPE during flow analysis
  • 723da96: 8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 19, 2021

Webrevs

Loading

@dimitryc
Copy link
Collaborator Author

@dimitryc dimitryc commented May 20, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

@dimitryc Since your change was applied there have been 4 commits pushed to the master branch:

  • 2a1129e: 8261022: Fix incorrect result of Math.abs() with char type
  • 31a8f04: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • 14df120: 8256809: Annotation processing causes NPE during flow analysis
  • 723da96: 8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM

Your commit was automatically rebased without conflicts.

Pushed as commit 717506c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dimitryc dimitryc deleted the backport-8244154 branch Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant