Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261395: C1 crash "cannot make java calls from the native compiler" #63

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link
Contributor

@VladimirKempik VladimirKempik commented May 19, 2021

Please review backport of JDK-8261395 to jdk15u-dev
Two chunks of instanceKlass.cpp wasn't applyting clean, slight mod were needed.
Testcase were adapted for jdk15 in testlibrary related header.
Test case fails before patch and passes after.
Original fix - openjdk/jdk@e828a93


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261395: C1 crash "cannot make java calls from the native compiler"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/63/head:pull/63
$ git checkout pull/63

Update a local copy of the PR:
$ git checkout pull/63
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/63/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 63

View PR using the GUI difftool:
$ git pr show -t 63

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/63.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 19, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e828a939a8155a3b4ab26811a405bb4e4b2b99e8 8261395: C1 crash "cannot make java calls from the native compiler" May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 19, 2021

Webrevs

Copy link
Collaborator

@yan-too yan-too left a comment

Fine with me

@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261395: C1 crash "cannot make java calls from the native compiler"

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 20, 2021
@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented May 20, 2021

/integrate

@openjdk openjdk bot closed this May 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

@VladimirKempik Since your change was applied there has been 1 commit pushed to the master branch:

  • 717506c: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files

Your commit was automatically rebased without conflicts.

Pushed as commit 0903e10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the JDK-8261395 branch May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants