Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented May 20, 2021

I'd like to backport JDK-8251456 to jdk15u for parity with jdk11u.
The original patch applied cleanly.

Slight changes is made to the test: added -XX:+IgnoreUnrecognizedVMOptions as suggested in JDK-8264179, - due to tier1 on win32 failed with "Unrecognized VM option 'UseCountedLoopSafepoints' ".

All regular tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8251456: [TESTBUG] compiler/vectorization/TestVectorsNotSavedAtSafepoint.java failed OutOfMemoryError

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/65/head:pull/65
$ git checkout pull/65

Update a local copy of the PR:
$ git checkout pull/65
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/65/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 65

View PR using the GUI difftool:
$ git pr show -t 65

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/65.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 51b3bd2c2e39fc379918d4fba325f26b2c6cd4ec 8251456: [TESTBUG] compiler/vectorization/TestVectorsNotSavedAtSafepoint.java failed OutOfMemoryError May 20, 2021
@openjdk
Copy link

openjdk bot commented May 20, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented May 20, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251456: [TESTBUG] compiler/vectorization/TestVectorsNotSavedAtSafepoint.java failed OutOfMemoryError

Removed allocation of large arrays to avoid OOME.

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a0b1ba1: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 20, 2021
@openjdk openjdk bot removed clean ready Pull request is ready to be integrated labels May 21, 2021
@omikhaltsova omikhaltsova marked this pull request as ready for review May 21, 2021 14:09
@openjdk openjdk bot added the rfr Pull request is ready for review label May 21, 2021
@mlbridge
Copy link

mlbridge bot commented May 21, 2021

Webrevs

@omikhaltsova
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented May 21, 2021

@omikhaltsova This PR has not yet been marked as ready for integration.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 21, 2021
@omikhaltsova
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 21, 2021
@openjdk
Copy link

openjdk bot commented May 21, 2021

@omikhaltsova
Your change (at version b35a64c) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented May 21, 2021

/sponsor

@openjdk openjdk bot closed this May 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 21, 2021
@openjdk
Copy link

openjdk bot commented May 21, 2021

@yan-too @omikhaltsova Since your change was applied there has been 1 commit pushed to the master branch:

  • a0b1ba1: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash

Your commit was automatically rebased without conflicts.

Pushed as commit 0f9e11c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants