Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255992: JFR EventWriter does not use first string from StringPool with id 0 #68

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link

@kvergizova kvergizova commented Jun 3, 2021

I'd like to backport JDK-8255992 to 15u as a prerequisite for JDK-8257621 and for parity with 11u.
The patch applies cleanly.
Tested with tier1 and jdk/jfr tests, the only failure is jdk/jfr/api/recording/event/TestReEnableName.java, that will be fixed by follow-up backport of JDK-8257621.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8255992: JFR EventWriter does not use first string from StringPool with id 0

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/68/head:pull/68
$ git checkout pull/68

Update a local copy of the PR:
$ git checkout pull/68
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/68/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 68

View PR using the GUI difftool:
$ git pr show -t 68

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/68.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 3, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport c85c9ad1f1b1b7aa358c587b654a2030927a65a8 8255992: JFR EventWriter does not use first string from StringPool with id 0 Jun 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 3, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 3, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255992: JFR EventWriter does not use first string from StringPool with id 0

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 3, 2021

Webrevs

Loading

@kvergizova
Copy link
Author

@kvergizova kvergizova commented Jun 4, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@kvergizova Pushed as commit f77ca30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kvergizova kvergizova deleted the backport-8255992 branch Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant