This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
8255992: JFR EventWriter does not use first string from StringPool with id 0 #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to backport JDK-8255992 to 15u as a prerequisite for JDK-8257621 and for parity with 11u.
The patch applies cleanly.
Tested with tier1 and jdk/jfr tests, the only failure is jdk/jfr/api/recording/event/TestReEnableName.java, that will be fixed by follow-up backport of JDK-8257621.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/68/head:pull/68
$ git checkout pull/68
Update a local copy of the PR:
$ git checkout pull/68
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/68/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 68
View PR using the GUI difftool:
$ git pr show -t 68
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/68.diff