Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files #8

Conversation

@VladimirKempik
Copy link
Contributor

@VladimirKempik VladimirKempik commented Apr 2, 2021

Please review this patch for 15u-dev.
applied almost cleanly, I have to remove last chunk in src/jdk.hotspot.agent/macosx/native/libsaproc/MacosxDebuggerLocal.m
from original patch as it was already present in jdk15u-dev and wasn't needed.
Very safe, fomatting only change, needed for rest of JNF removal patches to apply more cleanly


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/8.diff

Reviewed-by: serb, kizune, kcr, cjplummer
Backport-of: c32923e06fc94c2a2ad8b9dd803aad1ed5386505
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 2, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 2, 2021
@yan-too
yan-too approved these changes Apr 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 2, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 2, 2021
@yan-too
yan-too approved these changes Apr 2, 2021
@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 2, 2021

/integrate

@openjdk openjdk bot closed this Apr 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 2, 2021
@VladimirKempik VladimirKempik deleted the VladimirKempik:backport-c32923e06fc94c2a2ad8b9dd803aad1ed5386505 branch Apr 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@VladimirKempik Pushed as commit e245349.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants