8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821 #86
Conversation
👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@snazarkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@snazarkin |
/sponsor |
Going to push as commit a913893. |
@yan-too @snazarkin Pushed as commit a913893. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This follow up for JDK-8264821. Applies clean. All tests at java/nio/channels/FileChannel/ are green now.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/86/head:pull/86
$ git checkout pull/86
Update a local copy of the PR:
$ git checkout pull/86
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/86/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 86
View PR using the GUI difftool:
$ git pr show -t 86
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/86.diff