Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821 #86

Closed
wants to merge 1 commit into from

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented Jul 30, 2021

This follow up for JDK-8264821. Applies clean. All tests at java/nio/channels/FileChannel/ are green now.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/86/head:pull/86
$ git checkout pull/86

Update a local copy of the PR:
$ git checkout pull/86
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/86/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 86

View PR using the GUI difftool:
$ git pr show -t 86

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/86.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 30, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d1b28e7ad07bda33cd4e35b58b7f6dccfac3435c 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821 Jul 30, 2021
@openjdk
Copy link

openjdk bot commented Jul 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 30, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 30, 2021
@snazarkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 30, 2021
@openjdk
Copy link

openjdk bot commented Jul 30, 2021

@snazarkin
Your change (at version 8eaf8a0) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Jul 30, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 30, 2021

Going to push as commit a913893.

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 30, 2021
@openjdk
Copy link

openjdk bot commented Jul 30, 2021

@yan-too @snazarkin Pushed as commit a913893.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jul 30, 2021

Webrevs

@snazarkin snazarkin deleted the 8265231-backport branch August 3, 2021 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants