Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code #9

Closed
wants to merge 1 commit into from
Closed

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Apr 2, 2021

Please review this backport to jdk 15u-dev. Original patch didn't apply cleanly, most of issues were in CPrinterJob.m
due to changes introduced int jdk16&17. Rest was mostly context code difference.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/9/head:pull/9
$ git checkout pull/9

Update a local copy of the PR:
$ git checkout pull/9
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/9/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9

View PR using the GUI difftool:
$ git pr show -t 9

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/9.diff

…d 2D code

Backport-of: fa50877c2e86d1a4e00724dd29d934f52d51f42c
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 2, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2021

Webrevs

Copy link
Collaborator

@yan-too yan-too left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vladimir, that couple of printer-related bugfixes will be technical debt, and it will be upon you in 15!

@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 2, 2021
@VladimirKempik
Copy link
Author

Oh, well, if somebody will ask, we will look into it.
Purpose of this backport is to remove deps on JNF, not fix the printers.

@VladimirKempik
Copy link
Author

/integrate

@openjdk openjdk bot closed this Apr 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2021
@openjdk
Copy link

openjdk bot commented Apr 2, 2021

@VladimirKempik Pushed as commit 2798c72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants