Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8272602: [macos] not all KEY_PRESSED events sent when control modifier is used #91

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Aug 20, 2021

Clean backport to 15u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272602: [macos] not all KEY_PRESSED events sent when control modifier is used

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/91/head:pull/91
$ git checkout pull/91

Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/91/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 91

View PR using the GUI difftool:
$ git pr show -t 91

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/91.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ddcd851c43aa97477c7e406490c0c7c7d71ac629 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272602: [macos] not all KEY_PRESSED events sent when control modifier is used

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 20, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2021

Webrevs

@yan-too
Copy link
Collaborator

yan-too commented Aug 20, 2021

It would be nice to run some manual client tests in addition to the regular DEV run

@VladimirKempik
Copy link
Author

testing: jdk:tier1, tier2, netbeans autocompletion by crtl+space

@VladimirKempik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 20, 2021

Going to push as commit 3074e6b.

@openjdk openjdk bot closed this Aug 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@VladimirKempik Pushed as commit 3074e6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants