Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264848: [macos] libjvm.dylib linker warning due to macOS version mismatch #92

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Aug 26, 2021

Combined backport of 8264848 and 8272700 into jdk15u-dev, both apply cleanly in proper order


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8264848: [macos] libjvm.dylib linker warning due to macOS version mismatch
  • JDK-8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/92/head:pull/92
$ git checkout pull/92

Update a local copy of the PR:
$ git checkout pull/92
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/92/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 92

View PR using the GUI difftool:
$ git pr show -t 92

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/92.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 04fa1ed4d0d409bf9bd741297ca95c7f1b7a3e9f 8264848: [macos] libjvm.dylib linker warning due to macOS version mismatch Aug 26, 2021
@openjdk
Copy link

openjdk bot commented Aug 26, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 26, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264848: [macos] libjvm.dylib linker warning due to macOS version mismatch
8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 9a174b3: 8273671: Backport of 8260616 misses one JNF header inclusion removal
  • 0bc58f9: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance
  • 5c9dc7b: 8270317: Large Allocation in CipherSuite
  • 010d867: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • 148fe84: 8270216: [macOS] Update named used for Java run loop mode

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2021

Webrevs

@yan-too
Copy link
Collaborator

yan-too commented Aug 30, 2021

How about JDK-8272700 here?

@openjdk openjdk bot removed the clean label Sep 13, 2021
@VladimirKempik
Copy link
Author

VladimirKempik commented Sep 13, 2021

/issue add 8272700

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 13, 2021
@openjdk
Copy link

openjdk bot commented Sep 13, 2021

@VladimirKempik
Adding additional issue to issue list: 8272700: [macos] Build failure with Xcode 13.0 after JDK-8264848.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 13, 2021
@VladimirKempik
Copy link
Author

VladimirKempik commented Sep 13, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2021

Going to push as commit f75d51e.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 9a174b3: 8273671: Backport of 8260616 misses one JNF header inclusion removal
  • 0bc58f9: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance
  • 5c9dc7b: 8270317: Large Allocation in CipherSuite
  • 010d867: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • 148fe84: 8270216: [macOS] Update named used for Java run loop mode

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2021
@openjdk
Copy link

openjdk bot commented Sep 13, 2021

@VladimirKempik Pushed as commit f75d51e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants