New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268427: Improve AlgorithmConstraints:checkAlgorithm performance #96
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
@eastig This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
|
/integrate |
/sponsor |
Going to push as commit 0bc58f9. |
sun.security.util.AbstractAlgorithmConstraints.checkAlgorithm()
uses linear search to check if an algorithm has been disabled. Its execution time is high in the most common case: a checked algorithm is not disabled.This backport replaces the list with an ordered set. This improves
AbstractAlgorithmConstraints.checkAlgorithm()
performance, especially for permitted algorithms.The patch applies cleanly. Tier1 and tier2 tests pass with the patch. No unexpected failures.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/96/head:pull/96
$ git checkout pull/96
Update a local copy of the PR:
$ git checkout pull/96
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/96/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 96
View PR using the GUI difftool:
$ git pr show -t 96
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/96.diff