Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5 #98

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Sep 13, 2021

Clean backport to jdk15u-dev


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/98/head:pull/98
$ git checkout pull/98

Update a local copy of the PR:
$ git checkout pull/98
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/98/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 98

View PR using the GUI difftool:
$ git pr show -t 98

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/98.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dedddd5ab2e39a30a039d24f629a7974048b0923 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5 Sep 13, 2021
@openjdk
Copy link

openjdk bot commented Sep 13, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 13, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2021

Webrevs

@VladimirKempik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 14, 2021

Going to push as commit a01ebe3.

@openjdk openjdk bot closed this Sep 14, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2021
@openjdk
Copy link

openjdk bot commented Sep 14, 2021

@VladimirKempik Pushed as commit a01ebe3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant