8260927: StringBuilder::insert is incorrect without Compact Strings

Reviewed-by: redestad, alanb, rriggs, jlaskey
openjdk · Feb 2, 2021 · 081fa3e · 081fa3e · openjdk-notifier · Feb 2, 2021
1 parent ed1a775
commit 081fa3e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/java.base/share/classes/java/lang/String.java b/src/java.base/share/classes/java/lang/String.java
@@ -3621,7 +3621,7 @@ void getBytes(byte[] dst, int dstBegin, byte coder) {
      */
     void getBytes(byte[] dst, int srcPos, int dstBegin, byte coder, int length) {
         if (coder() == coder) {
-            System.arraycopy(value, srcPos, dst, dstBegin << coder, length << coder());
+            System.arraycopy(value, srcPos << coder, dst, dstBegin << coder, length << coder);
         } else {    // this.coder == LATIN && coder == UTF16
             StringLatin1.inflate(value, srcPos, dst, dstBegin, length);
         }

diff --git a/test/jdk/java/lang/StringBuilder/Insert.java b/test/jdk/java/lang/StringBuilder/Insert.java
@@ -27,9 +27,10 @@
 
 /**
  * @test
- * @run testng Insert
  * @bug 4914802 8257511
  * @summary Test StringBuilder.insert sanity tests
+ * @run testng/othervm -XX:-CompactStrings Insert
+ * @run testng/othervm -XX:+CompactStrings Insert
  */
 @Test
 public class Insert {