Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files
8259574: SIGSEGV in BFSClosure::closure_impl
Reviewed-by: stefank, egahlin
  • Loading branch information
Markus Grönlund committed Jan 18, 2021
1 parent d5ca3b3 commit cd25bf2ee7e083207c9cb344fd569146cab233ef
Showing 3 changed files with 2 additions and 3 deletions.
@@ -229,7 +229,7 @@ void BFSClosure::do_oop(narrowOop* ref) {
}

void BFSClosure::do_root(UnifiedOopRef ref) {
assert(!ref.is_null(), "invariant");
assert(ref.dereference() != NULL, "pointee must not be null");
if (!_edge_queue->is_full()) {
_edge_queue->add(NULL, ref);
}
@@ -57,7 +57,7 @@ template <typename Delegate>
void RootSetClosure<Delegate>::do_oop(narrowOop* ref) {
assert(ref != NULL, "invariant");
assert(is_aligned(ref, sizeof(narrowOop)), "invariant");
if (CompressedOops::is_null(*ref)) {
if (!CompressedOops::is_null(*ref)) {
_delegate->do_root(UnifiedOopRef::encode_in_native(ref));
}
}
@@ -524,7 +524,6 @@ class JavaThreadInVMAndNative : public StackObj {
};

static void post_events(bool exception_handler, Thread* thread) {
DEBUG_ONLY(JfrJavaSupport::check_java_thread_in_vm(thread));
if (exception_handler) {
EventShutdown e;
e.set_reason("VM Error");

1 comment on commit cd25bf2

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on cd25bf2 Jan 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.